[R-pkg-team] Bug#1071355: r-cran-maptools: FTBFS: Rgshhs.c:101:23: error: format not a string literal and no format arguments

[Santiago Vila]

Package: src:r-cran-maptools
Version: 1:1.1-8+dfsg-1
Severity: serious
Tags: ftbfs

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
  debian/rules binary
dh binary --buildsystem R
    dh_update_autotools_config -O--buildsystem=R
    dh_autoreconf -O--buildsystem=R
    dh_auto_configure -O--buildsystem=R
    dh_auto_build -O--buildsystem=R
    dh_auto_test -O--buildsystem=R
    create-stamp debian/debhelper-build-stamp
    dh_testroot -O--buildsystem=R
    dh_prep -O--buildsystem=R
    dh_auto_install --destdir=debian/r-cran-maptools/ -O--buildsystem=R
I: R packages needed for DEP8:
I: R Package: maptools Version: 1.1-8
I: Building using R version 4.4.0-2
I: R API version: r-api-4.0
I: Using built-time from d/changelog: Mon, 24 Jul 2023 19:12:46 +0200
	mkdir -p /<<BUILDDIR>>/r-cran-maptools-1.1-8\+dfsg/debian/r-cran-maptools/usr/lib/R/site-library
	R CMD INSTALL -l /<<BUILDDIR>>/r-cran-maptools-1.1-8\+dfsg/debian/r-cran-maptools/usr/lib/R/site-library --clean . "--built-timestamp='Mon, 24 Jul 2023 19:12:46 +0200'"
* installing *source* package ‘maptools’ ...
files ‘data/state.vbm.rda’, ‘data/wrld_simpl.rda’, ‘inst/shapes/baltim.dbf’, ‘inst/shapes/baltim.shp’, ‘inst/shapes/baltim.shx’, ‘inst/shapes/columbus.dbf’, ‘inst/shapes/columbus.shp’, ‘inst/shapes/columbus.shx’, ‘inst/shapes/pointZ.dbf’, ‘inst/shapes/pointZ.prj’, ‘inst/shapes/pointZ.shp’, ‘inst/shapes/pointZ.shx’, ‘inst/shapes/sids.dbf’, ‘inst/shapes/sids.shp’, ‘inst/shapes/sids.shx’ are missing
** using staged installation
** libs
using C compiler: ‘gcc (Debian 13.2.0-25) 13.2.0’
make[1]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -I"/usr/share/R/include" -DNDEBUG       -fpic  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/r-base-4.4.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c Rcentroid.c -o Rcentroid.o
gcc -I"/usr/share/R/include" -DNDEBUG       -fpic  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/r-base-4.4.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c Rgshhs.c -o Rgshhs.o
Rgshhs.c: In function ‘Rgshhs’:
Rgshhs.c:101:23: error: format not a string literal and no format arguments [-Werror=format-security]
   101 |                 error(msg);
       |                       ^~~
Rgshhs.c:341:47: error: format not a string literal and no format arguments [-Werror=format-security]
   341 |                                         error(msg);
       |                                               ^~~
cc1: some warnings being treated as errors
make[1]: *** [/usr/lib/R/etc/Makeconf:195: Rgshhs.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: Entering directory '/<<PKGBUILDDIR>>/src'
make[1]: Leaving directory '/<<PKGBUILDDIR>>/src'
ERROR: compilation failed for package ‘maptools’
* removing ‘/<<PKGBUILDDIR>>/debian/r-cran-maptools/usr/lib/R/site-library/maptools’
dh_auto_install: error: R CMD INSTALL -l /<<BUILDDIR>>/r-cran-maptools-1.1-8\+dfsg/debian/r-cran-maptools/usr/lib/R/site-library --clean . "--built-timestamp='Mon, 24 Jul 2023 19:12:46 +0200'" returned exit code 1
make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202405/

About the archive rebuild: The build was made on virtual machines
of type m6a.large and r6a.large from AWS, using sbuild and a
reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Thanks.