[R-pkg-team] Bug#1084351: r-cran-gert: FTBFS: utils.h:28:29: error: passing argument 10 of ‘git_commit_create’ from incompatible pointer type [-Wincompatible-pointer-types]

Mon Oct 7 09:40:15 BST 2024

Package: src:r-cran-gert
Version: 2.1.2+dfsg-1
Severity: serious
Tags: ftbfs

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
  debian/rules binary
dh binary --buildsystem R
    dh_update_autotools_config -O--buildsystem=R
    dh_autoreconf -O--buildsystem=R
    dh_auto_configure -O--buildsystem=R
    dh_auto_build -O--buildsystem=R
    debian/rules execute_after_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
cd inst/doc && Rscript -e "require(knitr); require(markdown); knit('gert.Rmd', 'gert.md'); markdownToHTML('gert.md', 'gert.html', options=c('use_xhtml', 'base64_images'));" && rm -f gert.md
Loading required package: knitr
Loading required package: markdown

processing file: gert.Rmd
1/16
2/16 [unnamed-chunk-1]
3/16
4/16 [setup]
5/16
6/16 [unnamed-chunk-2]
7/16
8/16 [unnamed-chunk-3]
9/16
10/16 [unnamed-chunk-4]
11/16
12/16 [unnamed-chunk-5]
13/16
14/16 [unnamed-chunk-6]
15/16
16/16 [unnamed-chunk-7]
output file: gert.md

[1] "gert.md"
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
    dh_auto_test -O--buildsystem=R
    create-stamp debian/debhelper-build-stamp
    dh_testroot -O--buildsystem=R
    dh_prep -O--buildsystem=R
    dh_auto_install --destdir=debian/r-cran-gert/ -O--buildsystem=R
I: R packages needed for DEP8: spelling, rmarkdown, testthat, ca-certificates
I: R Package: gert Version: 2.1.2
I: Building using R version 4.4.1-3
I: R API version: r-api-4.0
I: Using built-time from d/changelog: Wed, 25 Sep 2024 08:26:53 +0900
	mkdir -p /<<BUILDDIR>>/r-cran-gert-2.1.2\+dfsg/debian/r-cran-gert/usr/lib/R/site-library
	R CMD INSTALL -l /<<BUILDDIR>>/r-cran-gert-2.1.2\+dfsg/debian/r-cran-gert/usr/lib/R/site-library --clean . "--built-timestamp='Wed, 25 Sep 2024 08:26:53 +0900'"
* installing *source* package ‘gert’ ...
file ‘inst/doc/gert.html’ has the wrong MD5 checksum
** using staged installation
Found pkg-config cflags and libs!
Using PKG_CFLAGS=
Using PKG_LIBS=-lgit2
Configuration OK!
** libs
using C compiler: ‘gcc (Debian 14.2.0-6) 14.2.0’
make[1]: Entering directory '/<<PKGBUILDDIR>>/src'
rm -f gert.so branch.o clone.o commit.o config.o conflicts.o files.o ignore.o init.o merge.o rebase.o stash.o submodules.o tag.o utils.o version.o
gcc -I"/usr/share/R/include" -DNDEBUG -DR_NO_REMAP -DSTRICT_R_HEADERS     -fvisibility=hidden -fpic  -g -O2 -ffile-prefix-map=/build/reproducible-path/r-base-4.4.1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c branch.c -o branch.o
gcc -I"/usr/share/R/include" -DNDEBUG -DR_NO_REMAP -DSTRICT_R_HEADERS     -fvisibility=hidden -fpic  -g -O2 -ffile-prefix-map=/build/reproducible-path/r-base-4.4.1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c clone.c -o clone.o
gcc -I"/usr/share/R/include" -DNDEBUG -DR_NO_REMAP -DSTRICT_R_HEADERS     -fvisibility=hidden -fpic  -g -O2 -ffile-prefix-map=/build/reproducible-path/r-base-4.4.1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c commit.c -o commit.o
In file included from commit.c:2:
commit.c: In function ‘R_git_commit_create’:
utils.h:28:29: error: passing argument 10 of ‘git_commit_create’ from incompatible pointer type [-Wincompatible-pointer-types]
    28 | #define no_const_workaround (git_commit **)
commit.c:162:60: note: in expansion of macro ‘no_const_workaround’
   162 |                             msg.ptr, tree, number_parents, no_const_workaround parents), "git_commit_create");
       |                                                            ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/git2/repository.h:14,
                  from /usr/include/git2/annotated_commit.h:11,
                  from /usr/include/git2.h:11,
                  from utils.h:1:
/usr/include/git2/commit.h:369:27: note: expected ‘const git_commit **’ but argument is of type ‘git_commit **’
   369 |         const git_commit *parents[]);
       |         ~~~~~~~~~~~~~~~~~~^~~~~~~~~
make[1]: *** [/usr/lib/R/etc/Makeconf:195: commit.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: Entering directory '/<<PKGBUILDDIR>>/src'
make[1]: Leaving directory '/<<PKGBUILDDIR>>/src'
ERROR: compilation failed for package ‘gert’
* removing ‘/<<PKGBUILDDIR>>/debian/r-cran-gert/usr/lib/R/site-library/gert’
dh_auto_install: error: R CMD INSTALL -l /<<BUILDDIR>>/r-cran-gert-2.1.2\+dfsg/debian/r-cran-gert/usr/lib/R/site-library --clean . "--built-timestamp='Wed, 25 Sep 2024 08:26:53 +0900'" returned exit code 1
make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202410/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Thanks.