[R-pkg-team] Bug#934370: r-cran-fs: autopkgtest regression

[Jim Hester]

I am not sure, but the tests you are quoting in the email are coming
from the reprex package, not fs.

The test that is failing for fs on debian's machines is

```
> library(testthat)
> library(fs)
>
> test_check("fs")
-- 1. Error: dir_tree() works (@test-tree.R#4)  --------------------------------
Can't find `tests/testthat` in current directory.
1: withr::with_options(c(cli.unicode = FALSE), {
       reference <- fs::path_abs(test_path("ref-tree-1"))
       with_dir_tree(list(`foo/1` = ""), {
           expect_known_output(dir_tree("foo"), reference)
       })
   }) at testthat/test-tree.R:4
2: force(code)
3: fs::path_abs(test_path("ref-tree-1")) at testthat/test-tree.R:5
4: path_norm(path(getwd(), start))
5: test_path("ref-tree-1")
6: stop("Can't find `tests/testthat` in current directory.", call. = FALSE)

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 3350 | SKIPPED: 2 | WARNINGS: 0 | FAILED: 1 ]
1. Error: dir_tree() works (@test-tree.R#4)
```

Running the following works without error on my machine, I am not sure
what would be different on the debian build machines.

```
curl -LO 'https://cran.r-project.org/src/contrib/fs_1.3.1.tar.gz'
R CMD INSTALL fs_1.3.1.tar.gz
tar xf fs_1.3.1.tar.gz
cd fs/tests
for testfile in *.R; do
    LC_ALL=C.UTF-8 R --no-save < $testfile
done
```

On Mon, Aug 19, 2019 at 6:09 AM Andreas Tille <tille at debian.org> wrote:
>
> Control: forwarded -1 Jim Hester <james.f.hester at gmail.com>
>
> Hi Jim,
>
> as you can read below there is an issue with the test suite of fs
> version 1.3.1.  Do you have any hint whether we might do something
> wrong in calling the tests via:
>
>
> for testfile in *.R; do
>     LC_ALL=C.UTF-8 R --no-save < $testfile
> done
>
>
> or something else might cause these two failures?
>
> Kind regards
>
>       Andreas.
>
>
> On Sat, Aug 10, 2019 at 11:10:26AM +0200, Graham Inggs wrote:
> > Source: r-cran-fs
> > Version: 1.3.1+dfsg-1
> > Severity: serious
> > X-Debbugs-CC: debian-ci at lists.debian.org
> > User: debian-ci at lists.debian.org
> > Usertags: regression
> >
> > Hi Maintainer
> >
> > Since the upload of 1.3.1+dfsg-1, r-cran-fs has been failing its own
> > autopkgtests [1] with the following error:
> >
> > +   test_check("reprex")
> > + }
> > -- 1. Failure: make_filebase() works from absolute infile, outfile (@test-filepa
> > fs::path_dir(x) not equal to path_temp().
> > Classes differ: character is not fs_path/character
> >
> > -- 2. Failure: make_filebase() works from absolute infile, outfile (@test-filepa
> > fs::path_dir(x) not equal to path_temp().
> > Classes differ: character is not fs_path/character
> >
> > == testthat results  ===========================================================
> > OK: 25 SKIPPED: 55 FAILED: 2
> > 1. Failure: make_filebase() works from absolute infile, outfile
> > (@test-filepaths.R#25)
> > 2. Failure: make_filebase() works from absolute infile, outfile
> > (@test-filepaths.R#29)
> >
> > Error: testthat unit tests failed
> > Execution halted
> >
> > Regards
> > Graham
> >
> >
> > [1] https://ci.debian.net/packages/r/r-cran-fs/unstable/amd64/
> >
> > _______________________________________________
> > R-pkg-team mailing list
> > R-pkg-team at alioth-lists.debian.net
> > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/r-pkg-team
>
> --
> http://fam-tille.de