Bug#854335: python-websockets: Non-determistically FTBFS due to unreliable timing in tests

[Chris Lamb]

Source: python-websockets
Version: 3.2-1
Severity: serious
Justification: fails to build from source
User: reproducible-builds at lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Dear Maintainer,

python-websockets's testsuite appears to use method timing/benchmarking in such a way that it will non-deterministically FTBFS:

  […]
  
  ======================================================================
  FAIL: test_eof_received_timeout (websockets.test_protocol.ClientTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 792, in test_eof_received_timeout
      self.loop.run_until_complete(self.protocol.close(reason='close'))
    File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
      next(self.gen)
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 249, in assertCompletesWithin
      dt, max_time, "Too slow: {} >= {}".format(dt, max_time))
  AssertionError: 0.022619478404521942 not less than 0.019 : Too slow: 0.022619478404521942 >= 0.019
  
  ======================================================================
  FAIL: test_remote_close_race_with_failing_connection (websockets.test_protocol.ClientTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 716, in test_remote_close_race_with_failing_connection
      self.assertConnectionClosed(1011, '')
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 237, in assertConnectionClosed
      self.assertEqual(self.protocol.close_code, code)
  AssertionError: 1000 != 1011
  
  ======================================================================
  FAIL: test_close_handshake_timeout (websockets.test_protocol.ServerTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 761, in test_close_handshake_timeout
      self.loop.run_until_complete(self.protocol.close(reason='close'))
    File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
      next(self.gen)
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 249, in assertCompletesWithin
      dt, max_time, "Too slow: {} >= {}".format(dt, max_time))
  AssertionError: 0.0209119264036417 not less than 0.019 : Too slow: 0.0209119264036417 >= 0.019
  
  ----------------------------------------------------------------------
  Ran 235 tests in 2.067s
  
  FAILED (failures=3, skipped=29)
  E: pybuild pybuild:283: test: plugin distutils failed with: exit code=1: cd «BUILDDIR»/.pybuild/pythonX.Y_3.5/build; python3.5 -m unittest discover -v 
  dh_auto_test: pybuild --test -i python{version} -p 3.5 returned exit code 13
  debian/rules:5: recipe for target 'build' failed
  make: *** [build] Error 25
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

  […]

The full build log is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python-websockets.3.2-1.unstable.amd64.log.txt.gz
Type: application/octet-stream
Size: 3975 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-bugs/attachments/20170206/9557e95f/attachment-0001.obj>