Bug#860279: xmlrpc-c: please make the build reproducible

[Chris Lamb]

Source: xmlrpc-c
Version: 1.33.14-4
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that xmlrpc-c could not be built reproducibly due to including
the buildpath in the binary:

│ │ │ │ -BLDDIR="/build/1st/xmlrpc-c-1.33.14"
│ │ │ │ -ABS_SRCDIR="/build/1st/xmlrpc-c-1.33.14"
│ │ │ │ +BLDDIR="/build/xmlrpc-c-1.33.14/2nd"
│ │ │ │ +ABS_SRCDIR="/build/xmlrpc-c-1.33.14/2nd"

Patch attached. I believe this is only used really in the "tests"
makefile so it is safe to remove.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible_build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible_build.patch	2017-04-13 22:51:12.505698604 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-04-13
+
+--- xmlrpc-c-1.33.14.orig/GNUmakefile
++++ xmlrpc-c-1.33.14/GNUmakefile
+@@ -118,8 +118,6 @@ shell_config: $(BLDDIR)/config.mk
+ 	@echo 'PREFIX="$(PREFIX)"'					>>$@
+ 	@echo 'HEADERINST_DIR="$(HEADERINST_DIR)"'                      >>$@
+ 	@echo 'LIBINST_DIR="$(LIBINST_DIR)"'                            >>$@
+-	@echo 'BLDDIR="$(BLDDIR)"'                                      >>$@
+-	@echo 'ABS_SRCDIR="$(ABS_SRCDIR)"'                              >>$@
+ 	@echo '#######################################################' >>$@
+ 
+ xmlrpc-c-config xmlrpc-c-config.test:%: %.main shell_config
--- a/debian/patches/series	2017-04-13 22:36:58.493669764 +0100
--- b/debian/patches/series	2017-04-13 22:51:10.205687817 +0100
@@ -6,3 +6,4 @@
 614937_FTBFS_hurd-i386.patch
 fix-format-security.diff
 fix-FTBFS-gcc6.patch
+reproducible_build.patch