Bug#861896: manila: please make the build reproducible

[Chris Lamb]

Source: manila
Version: 1:3.0.0-5
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that manila could not be built reproducibly.

This is because you manually remove search.html which, in-turn,
means that dh-sphinx's cruft remover does not consider that
generated directory to be Sphinx documentation and thus it doesn't
clear up the cruft.

Patch attached that manually removes the .doctree directory and
.buildinfo file manually. As you suggest in debian/rules, fixing
the underlying problem that made you remove search.html manually
would be the best fix.

(See also: #861893)

Patch attached.


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2017-05-05 14:18:50.127739615 +0200
--- b/debian/rules	2017-05-05 14:56:00.926692934 +0200
@@ -72,5 +72,7 @@
 	# "search.html doesn't look like a Sphinx search page"
 	# and the package FTBFS
 	rm -f $(CURDIR)/debian/manila-doc/usr/share/doc/manila-doc/html/search.html
+	rm -f $(CURDIR)/debian/manila-doc/usr/share/doc/manila-doc/html/.buildinfo
+	rm -rf $(CURDIR)/debian/manila-doc/usr/share/doc/manila-doc/html/.doctrees
 	dh_sphinxdoc -O--buildsystem=python_distutils
 endif