Bug#890486: keepassxc: please make the build reproducible

[Chris Lamb]

Source: keepassxc
Version: 2.2.4+dfsg.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that keepassxc could not be built reproducibly.

This is because it embedded the absolute build path in the binary,
but this isn't needed in the Debian binaries.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/0001-Reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/0001-Reproducible-build.patch	2018-02-14 22:58:09.464695718 +0000
@@ -0,0 +1,17 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-02-14
+
+--- keepassxc-2.2.4+dfsg.1.orig/src/core/FilePath.cpp
++++ keepassxc-2.2.4+dfsg.1/src/core/FilePath.cpp
+@@ -223,10 +223,6 @@ FilePath::FilePath()
+     else if (testSetDir(appDirPath + "/share")) {
+     }
+ #endif
+-    // Last ditch test when running in the build directory (mainly for travis tests)
+-    else if (testSetDir(QString(KEEPASSX_SOURCE_DIR) + "/share")) {
+-    }
+-
+     if (m_dataPath.isEmpty()) {
+         qWarning("FilePath::DataPath: can't find data dir");
+     }
--- a/debian/patches/series	2018-02-14 22:40:13.071066885 +0000
--- b/debian/patches/series	2018-02-14 22:58:08.488689482 +0000
@@ -1 +1,2 @@
 0002-Add-code-to-detect-a-system-library-for-zxcvbn-with-.patch
+0001-Reproducible-build.patch