Bug#897904: libzstd: please make the build reproducible

[Chris Lamb]

Source: libzstd
Version: 1.3.4+dfsg-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that libzstd could not be built reproducibly.

This is because it encodes the number of CPUs of the build machine
into the documentation.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/0014-Reproducible-build.patch	1969-12-31 16:00:00.000000000 -0800
--- b/debian/patches/0014-Reproducible-build.patch	2018-05-04 08:29:31.826847092 -0700
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-05-04
+
+--- libzstd-1.3.4+dfsg.orig/contrib/pzstd/Options.cpp
++++ libzstd-1.3.4+dfsg/contrib/pzstd/Options.cpp
+@@ -88,7 +88,7 @@ void usage() {
+   std::fprintf(stderr, "  -p, --processes   #    : number of threads to use for (de)compression (default:%d)\n", defaultNumThreads());
+ 
+   std::fprintf(stderr, "ZSTD options:\n");
+-  std::fprintf(stderr, "  -#                     : # compression level (1-%d, default:%d)\n", kMaxNonUltraCompressionLevel, kDefaultCompressionLevel);
++  std::fprintf(stderr, "  -#                     : # compression level (1-%d, default:<numcpus>)\n", kMaxNonUltraCompressionLevel);
+   std::fprintf(stderr, "  -d, --decompress       : decompression\n");
+   std::fprintf(stderr, "  -o                file : result stored into `file` (only if 1 input file)\n");
+   std::fprintf(stderr, "  -f, --force            : overwrite output without prompting, (de)compress links\n");
--- a/debian/patches/series	2018-05-04 08:18:10.696779480 -0700
--- b/debian/patches/series	2018-05-04 08:29:29.170809935 -0700
@@ -3,3 +3,4 @@
 0012-typos.patch
 pthread.patch
 0013-skip-memory-greedy-tests.patch
+0014-Reproducible-build.patch