Bug#911234: mp3fs: please make the build reproducible

[Chris Lamb]

Source: mp3fs
Version: 0.91-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that mp3fs could not be built reproducibly.

This is because it used the current date in the manpage.

Patch attached that uses SOURCE_DATE_EPOCH instead.

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/specs/source-date-epoch/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible-build.patch	1969-12-31 19:00:00.000000000 -0500
--- b/debian/patches/reproducible-build.patch	2018-10-17 09:04:18.204251101 -0400
@@ -0,0 +1,21 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2018-10-17
+
+--- mp3fs-0.91.orig/Makefile.am
++++ mp3fs-0.91/Makefile.am
+@@ -6,9 +6,13 @@ MAINTAINERCLEANFILES = mp3fs.1
+ 
+ EXTRA_DIST = INSTALL.md README.md mp3fs.1.txt
+ 
++DATE_FMT = %B %Y
++SOURCE_DATE_EPOCH ?= $(shell date +%s)
++REVDATE = $(shell date -u -d "@(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null || date -u "+$(DATE_FMT)")
++
+ mp3fs.1: mp3fs.1.txt
+ 	$(AM_V_GEN)a2x -a revnumber="$(VERSION)" \
+-		-a revdate="$(shell date +'%B %Y')" -f manpage $<
++		-a revdate="$(REVDATE)" -f manpage $<
+ 
+ # Remove absolutely every generated file
+ .PHONY: squeaky-clean
--- a/debian/patches/series	1969-12-31 19:00:00.000000000 -0500
--- b/debian/patches/series	2018-10-17 08:50:43.738373945 -0400
@@ -0,0 +1 @@
+reproducible-build.patch