Bug#977416: klayout: reproducible builds: /usr/bin/klayout broken when /bin/sh points to bash

[Vagrant Cascadian]

Source: klayout
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

When /bin/sh points to bash, the generated /usr/bin/klayout contains the
'\n' character intended instead of the intended newline.

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/klayout.html

  ./usr/bin/klayout
  1 #!/bin/sh	 
  2 LD_LIBRARY_PATH=/usr/lib/klayout·exec·/usr/lib/klayout/klayout·"$@"  1 #!/bin/sh\nLD_LIBRARY_PATH=/usr/lib/klayout·exec·/usr/lib/klayout/klayout·"$@"


The attached patch fixes this by making two calls to echo when
generating /usr/bin/klayout.


This patch alone does not resolve all reproducibility issues (e.g. build
paths), but when combined with the timestamp patch just submitted,
should result in a reproducible build when it lands in bullseye, where
build paths are not varied.


Thanks for maintaining klayout!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-debian-rules-Generate-klayout-script-consistently-re.patch
Type: text/x-diff
Size: 1514 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20201214/1642e454/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20201214/1642e454/attachment.sig>