Bug#990247: vlc: reproducible builds: Fix passing sort order to tar when generating default.vlt

[Vagrant Cascadian]

Source: vlc
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

In share/Makefile.am, when creating default.vlt it attempts to detect
the availability of the tar --sort= option, but then incorrectly passes
the variable to tar.

It does not appear to affect the sort order on
tests.reproducible-builds.org, but it does appear to cause issues when
testing with reprotest, and so may occur in other situations in the
wild.


The attached patch fixes this by passing it as a make variable rather
than a quoted shell variable.


This patch does not address all reproducibility issues in vlc
(e.g. build paths).


Thanks for maintaining vlc!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Pass-sort-option-to-tar-as-a-make-variable-when-crea.patch
Type: text/x-diff
Size: 1218 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20210623/efa01ce3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20210623/efa01ce3/attachment.sig>