Bug#995131: nut: reproducible builds: udev rules vary depending readdir order

[Vagrant Cascadian]

Source: nut
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

The comments for various udev rules list different drivers for some
devices.

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/i386/diffoscope-results/nut.html

  /lib/udev/rules.d/62-nut-usbups.rules

  Krauler·UP-M500VA··-·blazer_usb
  vs.
  Krauler·UP-M500VA··-·nutdrv_qx

The udev rules are generated from tools/nut-usbinfo.pl reading the files
in ../drivers/, using perl's File::Find, which does not reliably return
the same file ordering. In some cases, multiple drivers claim support
for a given device, and which driver gets embedded into the udev
comments depends on the order in which the directory contents were
returned.

The attached patch fixes this by sorting the directory output.

With this patch applied, nut should become reproducible on
tests.reproducible-builds.org.

Our test infrastructure seems to only reliably catch this issue on i386
and armhf (e.g. 32-bit architectures).


Thanks for maintaining nut!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nut-usbinfo.pl-Sort-the-directory-scan-results.patch
Type: text/x-diff
Size: 1005 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20210926/90e1ea7e/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20210926/90e1ea7e/attachment.sig>