Bug#998104: afnix: please make the build reproducible

[Chris Lamb]

Source: afnix
Version: 3.5.0-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
afnix could not be built reproducibly.

This is because it uses components of uname(1) as defines, and then
these defines are included in a .hpp file:

│ │ │ ├── ./usr/include/afnix/plt/ccnf.hpp
│ │ │ │ @@ -80,19 +80,19 @@
│ │ │ │  #define  AFNIX_PROCNAME_S390      "s390"
│ │ │ │  #define  AFNIX_PROCNAME_S390X     "s390x"
│ │ │ │  #define  AFNIX_PROCNAME_X64       "x64"
│ │ │ │  #define  AFNIX_PROCNAME_SH        "sh"
│ │ │ │  
│ │ │ │  // platform definitions
│ │ │ │  #define  AFNIX_PLATFORM_PLATID    1
│ │ │ │ -#define  AFNIX_PLATFORM_VERSION   5.14
│ │ │ │ +#define  AFNIX_PLATFORM_VERSION   5.10
│ │ │ │  #define  AFNIX_PLATFORM_MAJOR     5
│ │ │ │ -#define  AFNIX_PLATFORM_MINOR     14
│ │ │ │ +#define  AFNIX_PLATFORM_MINOR     10
│ │ │ │  #define  AFNIX_PLATFORM_NAME      "linux"
│ │ │ │ -#define  AFNIX_PLATFORM_VINFO     "5.14"
│ │ │ │ +#define  AFNIX_PLATFORM_VINFO     "5.10"
│ │ │ │  #define  AFNIX_PLATFORM_PROCID    13
│ │ │ │  #define  AFNIX_PLATFORM_PROC      "x64"
│ │ │ │  #define  AFNIX_PLATFORM_BITS      64
│ │ │ │  
│ │ │ │  // configuration definitions
│ │ │ │  #define  AFNIX_LINKTYPE_STATIC    false

Patch attached that forces these to the equivalent of having a
kernel version of "0.0". Not ideal, but it doesn't seem clear
that these defines are ever used (beyond being included in -v
output or something).

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/0014-Reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/0014-Reproducible-build.patch	2021-10-30 11:30:22.237291469 +0100
@@ -0,0 +1,25 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2021-10-30
+
+--- afnix-3.5.0.orig/cnf/bin/afnix-setup
++++ afnix-3.5.0/cnf/bin/afnix-setup
+@@ -256,15 +256,15 @@ gendef () {
+     if test "$?" != "0"; then
+         error "cannot determine platform name"
+     fi
+-    pltvrs=`$pltexe -v`
++    pltvrs=0.0
+     if test "$?" != "0"; then
+         error "cannot determine platform version"
+     fi
+-    pltmaj=`$pltexe -M`
++    pltmaj=0
+     if test "$?" != "0"; then
+         error "cannot determine platform major number"
+     fi
+-    pltmin=`$pltexe -m`
++    pltmin=0
+     if test "$?" != "0"; then
+         error "cannot determine platform minor number"
+     fi
--- a/debian/patches/series	2021-10-30 11:12:44.345382557 +0100
--- b/debian/patches/series	2021-10-30 11:30:19.285275102 +0100
@@ -11,3 +11,4 @@
 0012-Add-support-ppc64.patch
 0013-Disable-nwg-test.patch
 0014-Use-dpkg-buildflags-for-gcc11.patch
+0014-Reproducible-build.patch