Bug#1003430: gkrellm-leds: reproducible-builds: /bin/sh dependent behavior in Makefile

[Vagrant Cascadian]

Source: gkrellm-leds
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

The path that gkrellm-leds installs plugins into differs depending on
weather /bin/sh points to bash or dash:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/gkrellm-leds.html

In the md5sums file you have two different files included in the package:

  usr/lib/gkrellm2/plugins/gkleds.so
vs.
  build/gkrellm-leds-0.8.0/debian/.debhelper/generated/_source/home/.gkrellm2/plugins/gkleds.so


The attached patch fixes this by removing the UID check in the Makefile,
which only behaves "correctly" when run under bash (when run under dash
$UID is unset).

Since the .deb package should always install into
/usr/lib/gkrellm2/plugins, regardless of the running UID, removing the
check seems appropriate, especially as "Rules-Requires-Root: no" is set
in debian/control.


With this patch applied, gkrellm-leds should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining gkrellm-leds!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Makefile-Disable-broken-UID-check.patch
Type: text/x-diff
Size: 1167 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20220109/5f57f9fe/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20220109/5f57f9fe/attachment.sig>