Bug#1005954: jcabi-aspects: please make the build partly reproducible

[Chris Lamb]

Source: jcabi-aspects
Version: 0.22.6-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: filesystem
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
jcabi-aspects could not be built reproducibly.

This is because it embedded a builddef-jcabi-aspects.lst in the
generated .JAR file via the aspectj:compile plugin [1] defined in the
package's pom.xml file. This .lst file contained contents based on the
fileystem ordering.

Patch attached that strips this file from the .jar, but it may be
possible and simpler to drop this <plugin>...</plugin> from the
pom.xml entirely; I am just not sure it is used.

An alternative approach could be to patch this plugin to make it (or,
more likely whatever drives *its* input) to iterate over the sorted
order.

 [0] https://reproducible-builds.org/
 [1] https://www.mojohaus.org/aspectj-maven-plugin/compile-mojo.html#argumentFileName


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-

-------------- next part --------------
--- a/debian/control	2022-02-17 17:19:23.386648743 -0800
--- b/debian/control	2022-02-17 17:36:45.140110914 -0800
@@ -12,6 +12,7 @@
  , libjcabi-log-java
  , libmaven-bundle-plugin-java
  , libtemplating-maven-plugin-java
+ , zip
 Standards-Version: 4.5.1
 Rules-Requires-Root: no
 Vcs-Git: https://salsa.debian.org/java-team/jcabi-aspects.git
--- a/debian/rules	2022-02-17 17:19:23.386648743 -0800
--- b/debian/rules	2022-02-17 17:36:04.528072026 -0800
@@ -9,3 +9,6 @@
 
 %:
 	dh $@
+
+execute_after_dh_install:
+	zip -d debian/libjcabi-aspects-java/usr/share/java/jcabi-aspects-*.jar builddef-jcabi-aspects.lst