Bug#1010233: glibc: reproducible builds: different file permissions on ld.so.conf* and others

[Vagrant Cascadian]

Source: glibc
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Changes in the experimental packaging cause the umask of the build user
to affect the permissions of numerous files that are excluded from the
dh_fixperms call:

  https://tests.reproducible-builds.org/debian/rb-pkg/experimental/arm64/diffoscope-results/glibc.html

  glibc-source_2.34-0experimental4_all.deb

  -rw-r--r--···0·root ... ./usr/src/glibc/debian/local/etc/ld.so.conf
  -rw-r--r--···0·root ... ./usr/src/glibc/debian/patches/any/local-ldconfig-ignore-ld.so.diff
vs.
  -rw-rw-r--···0·root ... ./usr/src/glibc/debian/local/etc/ld.so.conf
  -rw-rw-r--···0·root ... ./usr/src/glibc/debian/patches/any/local-ldconfig-ignore-ld.so.diff

  libc-bin_2.34-0experimental4_arm64.deb

  -rw-r--r--···0·root·········(0)·root·········(0)·······34·2019-07-29·09:56:57.000000·./etc/ld.so.conf
  drwxr-xr-x···0·root·········(0)·root·········(0)········0·2019-07-29·09:56:57.000000·./etc/ld.so.conf.d/
  -rw-r--r--···0·root·········(0)·root·········(0)·······44·2019-07-29·09:56:57.000000·./etc/ld.so.conf.d/libc.conf
vs.  
  -rw-rw-r--···0·root·········(0)·root·········(0)·······34·2019-07-29·09:56:57.000000·./etc/ld.so.conf
  drwxrwxr-x···0·root·········(0)·root·········(0)········0·2019-07-29·09:56:57.000000·./etc/ld.so.conf.d/
  -rw-rw-r--···0·root·········(0)·root·········(0)·······44·2019-07-29·09:56:57.000000·./etc/ld.so.conf.d/libc.conf


The attached patch fixes this by removing some exclusions from
dh_fixperms calls and explicitly marking the desired files as
executable.

The patch does appear to have some side-effects setting various library
files as executable that were not previously:

  -rw-r--r--  root/root   /lib32/libBrokenLocale.so.1
vs.
  -rwxr-xr-x  root/root   /lib32/libBrokenLocale.so.1

Weather this is desireable or undesireable I'm not sure... further
adjustments could be made to fix this either way, of course.


With this patch applied, glibc should become reproducible on
tests.reproducible-builds.org again!


Thanks for maintaining glibc!


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debian-rules.d-debhelper.mk-Fix-permissions-on-libc..patch
Type: text/x-diff
Size: 1733 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20220426/5af4563e/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20220426/5af4563e/attachment.sig>