Bug#1021466: pacman: reproducible-builds: build path embedded in /usr/games/pacman

[Vagrant Cascadian]

Source: pacman
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

The build path is embedded in /usr/games/pacman:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/pacman.html

  /build/1st/pacman-10/pac.cc:85
  vs.
  /build/2/pacman-10/2nd/pac.cc:85

The attached patch fixes this adjusting the generated Makefile from
debian/rules to include -ffile-prefix-map in the CXXFLAGS_DEFINES
variable.

Alternately, it might be worth using "dpkg-buildflags --get CXXFLAGS"
instead of hard-coding -ffile-prefix-map, and will benefit from other
useful flags as well.

According to my local tests, with this patch applied, pacman should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining pacman!

live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debian-rules-Add-ffile-prefix-map-to-CXXEXTRA_DEFINE.patch
Type: text/x-diff
Size: 767 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20221008/a992d1db/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20221008/a992d1db/attachment.sig>