Bug#1027988: click: please make the build reproducible

[Chris Lamb]

Source: click
Version: 0.5.0-9
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
click could not be built reproducibly.

This is because a config.py file included the value of
abs_top_builddir. Maybe the value is not actually used after
installation as it seems to be related to compiling things using GCC
(although it might be needed for the autopkgtests?).

Patch attached that sets it to where click actually gets installed to.
At the very least, the build directory perforce does not exist anymore
at package installation time, so this is "no worse", so to speak.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-


-------------- next part --------------
--- a/debian/rules	2023-01-04 16:43:11.122429535 +0000
--- b/debian/rules	2023-01-05 15:44:20.157606980 +0000
@@ -55,6 +55,8 @@
 	rm debian/tmp/usr/lib/*/libclick-0.4.la
 	dh_install
 	DH_AUTOSCRIPTDIR=debhelper debhelper/dh_click --name=click-desktop
+	sed -i -e 's@\(abs_top_builddir = \).*@\1 "/usr/lib/python3/dist-packages/click_package"@g' \
+		debian/python3-click-package/usr/lib/python3/dist-packages/click_package/tests/config.py
 
 override_dh_missing:
 	dh_missing --fail-missing