Bug#1034423: php8.2: reproducible-builds: Paths to sed in php-config8.2 and and phpize8.2

[Vagrant Cascadian]

Source: php8.2
Severity: serious
Justification: TC resolution #994388
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

The paths to sed are embedded in two scripts shipped in /usr/bin:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/php8.2.html

  /usr/bin/php-config8.2

  SED="/bin/sed"
  vs.
  SED="/usr/bin/sed"

It appears this was attempted to be fixed in an earlier php package, but
the fix was either never effective, or has for some reason become
ineffective:

  https://bugs.debian.org/1015188

The attached patch fixes this by explicitly specifying the /usr/bin
path, which is compatible with both usrmerge and non-usrmerge systems.

Other approaches would be to adapt configure to be able to override the
autodetection of the path for SED, or perhaps ideal would be to specify
SED without any path, assuming it is always run in an environment where
PATH is set correctly.

Unfortunately, there are other outstanding issues and this patch is not
sufficient to make php8.2 reproducible, but it should reduce the
differences.

Thanks for maintaining php8.2!

live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-scripts-php-.in-Explicitly-define-the-path-to-sed.patch
Type: text/x-diff
Size: 1459 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20230414/aee02ead/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20230414/aee02ead/attachment.sig>