Bug#1039865: valgrind: reproducible-builds: differing permissions on debian.supp

[Vagrant Cascadian]

Source: valgrind
Severity: normal
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

The permissions debian.supp differs depending on the umask of the build
environment:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/valgrind.html

  -rw-r--r--···0·root·········(0)·root·········(0)·····1136·2022-08-28·10:40:16.000000·./usr/lib/valgrind/debian.supp
  vs.
  -rw-rw-r--···0·root·········(0)·root·········(0)·····1136·2022-08-28·10:40:16.000000·./usr/lib/valgrind/debian.supp


The attached patch to debian/rules explicitly sets the permissions on
debian.supp after dh_fixperms is run.

Another approach is to remove the exclusion on .supp files from the
dh_fixperms call, though presumeably this was added for a reason and
that might need to be fixed some other way.

According to my local tests, with this patch applied valgrind should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining valgrind!

live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debian-rules-Explicitly-set-permissions-on-debian.su.patch
Type: text/x-diff
Size: 765 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20230628/570a7d5e/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20230628/570a7d5e/attachment.sig>