Bug#1085097: python-roborock: please make the build reproducible

[Chris Lamb]

Source: python-roborock
Version: 2.6.0-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
python-roborock could not be built reproducibly.

This is because most/every documentation page embedded an arbitrary
memory reference:

│ │ │ ├── ./usr/share/doc/python3-roborock/html/api_commands.html
│ │ │ │ @@ -2094,15 +2094,15 @@
[…]
│ │ │ │    <div role="contentinfo">
│ │ │ │ -<jinja2.runtime.BlockReference object at 0x7f12ce67be30>
│ │ │ │ +<jinja2.runtime.BlockReference object at 0x7fb1f1b54230>
│ │ │ │  <p>We are looking for contributors to […]

... which was in turn caused by a faulty call to super() that was
also presumably masking the actual footer content.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/Fix-call-to-super-in-docs.patch	1969-12-31 16:00:00.000000000 -0800
--- b/debian/patches/Fix-call-to-super-in-docs.patch	2024-10-14 07:47:09.380824941 -0700
@@ -0,0 +1,13 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2024-10-14
+
+--- python-roborock-2.6.0.orig/docs/source/_templates/footer.html
++++ python-roborock-2.6.0/docs/source/_templates/footer.html
+@@ -1,5 +1,5 @@
+ {% extends "!footer.html" %}
+ {%- block contentinfo %}
+-{{ super }}
++{{ super() }}
+ <p>We are looking for contributors to help with our documentation, if you are interested please <a href="https://github.com/humbertogontijo/python-roborock">contribute here.</a>
+ {% endblock %}
--- a/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
--- b/debian/patches/series	2024-10-14 07:47:08.284828460 -0700
@@ -0,0 +1 @@
+Fix-call-to-super-in-docs.patch