Bug#1098809: needrestart: please add apt to build-depends

[Holger Levsen]

Package: needrestart
Version: 3.8.2
Severity: important
User: reproducible-builds at lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Dear Maintainer,

please add apt to needrestart's build-depends, else one cannot simple rebuild
the package as https://reproduce.debian.net/all/api/v0/builds/212904/log
shows.

(apt is installed on the buildds, thus this issue is hardly noticed. Thus when
rebuilding the package using the .buildinfo file from the buildds, apt is not
present there as it's omitted by dpkg when writing the .buildinfo file (precicely
because it's not listed as build-depends) and thus when we try to rebuild
the package it fails.)

The relevant part of that log is probably:

[...]
make[3]: Leaving directory '/build/reproducible-path/needrestart-3.8/perl'
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/hook.d"
cp hooks/* "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/hook.d/"
cp ex/needrestart.conf "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/"
cp ex/notify.conf "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/"
cp ex/iucode.sh "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/conf.d"
cp ex/conf.d/* "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/conf.d/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/notify.d"
cp ex/notify.d/* "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/notify.d/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/restart.d"
cp ex/restart.d/* "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/restart.d/"
command -v apt-get > /dev/null && \
    mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/apt/apt.conf.d" && cp ex/apt/needrestart-apt_d "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/apt/apt.conf.d/99needrestart" && \
    mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/dpkg/dpkg.cfg.d" && cp ex/apt/needrestart-dpkg_d "/build/reproducible-path/needrestart-3.8/debian/tmp/etc/dpkg/dpkg.cfg.d/needrestart" && \
    mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/lib/needrestart" && cp ex/apt/dpkg-status ex/apt/apt-pinvoke "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/lib/needrestart" || true
command -v debconf > /dev/null && \
    mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/share/needrestart" && \
    po2debconf ex/debconf/needrestart.templates > "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/share/needrestart/needrestart.templates" || true
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/share/polkit-1/actions"
cp ex/polkit/net.fiasko-nw.needrestart.policy "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/share/polkit-1/actions/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/sbin"
cp needrestart "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/sbin/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/lib/needrestart"
cp lib/iucode-scan-versions "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/lib/needrestart/"
cp lib/vmlinuz-get-version "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/lib/needrestart/"
cp lib/notify.d.sh "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/lib/needrestart/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/share/locale"
cp -r po/.build/* "/build/reproducible-path/needrestart-3.8/debian/tmp/usr/share/locale/"
mkdir -p "/build/reproducible-path/needrestart-3.8/debian/tmp/var/cache/needrestart"
make[2]: Leaving directory '/build/reproducible-path/needrestart-3.8'
rm /build/reproducible-path/needrestart-3.8/debian/tmp/etc/needrestart/hook.d/30-pacman
make[1]: Leaving directory '/build/reproducible-path/needrestart-3.8'
   dh_install -i
dh_install: warning: Cannot find (any matches for) "etc/dpkg/dpkg.cfg.d/needrestart" (tried in ., debian/tmp)

dh_install: warning: needrestart missing files: etc/dpkg/dpkg.cfg.d/needrestart
dh_install: warning: Cannot find (any matches for) "etc/apt/apt.conf.d/99needrestart" (tried in ., debian/tmp)

dh_install: warning: needrestart missing files: etc/apt/apt.conf.d/99needrestart
dh_install: error: missing files, aborting
make: *** [debian/rules:4: binary-indep] Error 255
dpkg-buildpackage: error: debian/rules binary-indep subprocess returned exit status 2


& many thanks for maintaining needrestart! I love it! :)


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Any business accepting Bitcoin is participating in the human race’s suicide.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-bugs/attachments/20250224/c73c5998/attachment.sig>