Bug#1102289: src:pcp modifies debian/control during the build

[Jochen Sprickerhof]

Source: pcp
Version: 6.3.7-1
Severity: serious
X-Debbugs-Cc: Helmut Grohne <helmutg at debian.org>, reproducible-bugs at lists.alioth.debian.org
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildinfo

Hi,

src:pcp modifies the debian/control file during the build:

=== debian ===
make[2]: Entering directory '/build/reproducible-path/pcp-6.3.7/debian'
./fixcontrol >control
cat control.python3 >>control
cat control.pcpgui >>control
cat control.pcp2xlsx >>control
cat control.pmdaib >>control
cat control.perl >>control
make[2]: Leaving directory '/build/reproducible-path/pcp-6.3.7/debian'

https://buildd.debian.org/status/fetch.php?pkg=pcp&arch=amd64&ver=6.3.7-1&stamp=1743138375&raw=0

This is forbidding by the ftp-master REJECT-FAQ:

| Putting all of that together, you can simplify it with debian/control
| has to contain a list of binaries to be built before the build-process
| starts, do not modify that in the running build-process.

https://ftp-master.debian.org/REJECT-FAQ.html

And makes the package not reproducible on reproduce.debian.net:

https://reproduce.debian.net/amd64/#pcp

I would also recommend looking into dh (package debhelper) or dh-debputy
instead of maintaining debian/rules by hand.

Thanks to Helmut for figuring this out!

Cheers Jochen