Bug#1120874: python-altair: please make the build reproducible

[Chris Lamb]

Source: python-altair
Version: 5.0.1-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
python-altair could not be built reproducibly.

This is because it ships a different binary package depending on
whether the testsuite is run or not.

Specifically, it does not remove the "tools" directory that is added
via PYBUILD_BEFORE_TEST. A patch is attached that will remove this
directory as well, but if the binary package really does need this
directory at runtime for whatever reason (e.g. for autopkgtests),
then the package needs to ensure that this directory exists regardless
of whether nocheck is specified.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-11-17 11:27:13.834542574 -0800
--- b/debian/rules	2025-11-17 11:37:53.845631551 -0800
@@ -13,6 +13,7 @@
 # Skip test requiring internet connection
 export PYBUILD_TEST_ARGS=tests/ --verbose -k 'not test_render_examples_to_chart and not test_from_and_to_json_roundtrip and not test_save_html and not test_selection_deprecation'
 export PYBUILD_BEFORE_TEST=cp -a tools {build_dir}
+export PYBUILD_AFTER_TEST=rm -rfv {build_dir}/tools/
 
 %:
 	#dh $@ --with sphinxdoc --buildsystem=pybuild