Bug#1120876: python-phabricator: please make the build reproducible

[Chris Lamb]

Source: python-phabricator
Version: 0.9.1-0.1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
python-phabricator could not be built reproducibly.

This is because it ships a different binary package depending on
whether the testsuite is run or not.

Specifically, it does not remove the "resources" directory that is
added via PYBUILD_BEFORE_TEST. A patch is attached that will remove
this directory after running the tests, but if the binary package
really does need this directory at runtime for whatever reason (e.g.
for autopkgtests), then the package needs to ensure that this directory
exists regardless of whether nocheck is specified or not.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-11-17 11:26:33.158211460 -0800
--- b/debian/rules	2025-11-17 11:30:10.981518169 -0800
@@ -2,6 +2,7 @@
 
 export PYBUILD_NAME = phabricator
 export PYBUILD_BEFORE_TEST=mkdir -p {build_dir}/phabricator/tests/resources/ ; cp -v {dir}/phabricator/tests/resources/* {build_dir}/phabricator/tests/resources/
+export PYBUILD_AFTER_TEST=rm -rfv {build_dir}/phabricator/tests/resources/
 
 %:
 	dh $@ --buildsystem=pybuild