Bug#1121794: golang-github-spf13-afero: please make the build reproducible

[Chris Lamb]

Source: golang-github-spf13-afero
Version: 1.15.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
golang-github-spf13-afero could not be built reproducibly.

This is because the package removed a file — but only if the tests
were run.

Patch attached that moves this removal to the unconditionally executed
execute_before_dh_auto_install target.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-12-02 12:05:07.341925548 -0800
--- b/debian/rules	2025-12-02 12:12:26.264698597 -0800
@@ -1,9 +1,9 @@
 #!/usr/bin/make -f
 
-export DH_GOLANG_EXCLUDES := gcsfs
+export DH_GOLANG_EXCLUDES := gcsfs file1
 
 %:
 	dh $@ --builddirectory=_build --buildsystem=golang
 
-execute_after_dh_auto_test:
-	rm -rv _build/src/github.com/spf13/afero/sftpfs/test/
+execute_before_dh_auto_install:
+	rm -rfv _build/src/github.com/spf13/afero/sftpfs/test/