Bug#1121860: golang-github-foxboron-go-tpm-keyfiles: please make the build reproducible

[Chris Lamb]

Source: golang-github-foxboron-go-tpm-keyfiles
Version: 0.0~git20250520.c3c3a4e-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
golang-github-foxboron-go-tpm-keyfiles could not be built reproducibly.

This is because the call to remove files were in the wrong debian/rules
target. Whilst it was in override_dh_auto_test, this target is not
called if the tests are skipped... meaning that if the tests are *not*
run, then the package contains those files.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-12-03 11:43:01.180473424 -0800
--- b/debian/rules	2025-12-03 11:51:00.939467558 -0800
@@ -3,7 +3,7 @@
 %:
 	dh $@ --builddirectory=_build --buildsystem=golang
 
-override_dh_auto_test:
+override_dh_auto_build:
 #src/github.com/foxboron/go-tpm-keyfiles/importablekey_test.go:12:2: cannot find package "github.com/google/go-tpm/tpm2/transport/simulator" in any of:
 #src/github.com/foxboron/go-tpm-keyfiles/loadablekey_test.go:10:2: cannot find package "github.com/google/go-tpm/tpm2/transport/simulator" in any of:
 #src/github.com/foxboron/go-tpm-keyfiles/keyfile_test.go:17:2: cannot find package "github.com/foxboron/swtpm_test" in any of:
@@ -14,4 +14,3 @@
 	rm -fv _build/src/github.com/foxboron/go-tpm-keyfiles/keyfile_test.go
 	rm -fv _build/src/github.com/foxboron/go-tpm-keyfiles/tpm_test.go
 	rm -fv _build/src/github.com/foxboron/go-tpm-keyfiles/sealedkey_test.go
-	dh_auto_test $(DH_BUILD_OPTS)