Bug#1122824: golang-github-google-go-attestation: please make the build reproducible

[Chris Lamb]

Source: golang-github-google-go-attestation
Version: 0.5.1-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
golang-github-google-go-attestation could not be built reproducibly.

This is because the call to remove some tests were essentially in the
wrong debian/rules target. Whilst it they were in execute_before_dh_auto_test,
this target is not called if the tests are skipped — meaning that if the tests
_aren't_ run, then the package contains those files.

Patch attached that moves these deletions to execute_after_dh_auto_build
which is always run.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2025-12-12 11:51:34.578343520 -0800
--- b/debian/rules	2025-12-12 11:55:20.343494389 -0800
@@ -7,7 +7,7 @@
 %:
 	dh $@ --builddirectory=_build --buildsystem=golang
 
-execute_before_dh_auto_test:
+execute_after_dh_auto_build:
 # src/github.com/google/go-attestation/attest/attest_simulated_tpm20_test.go:29:2: cannot find package "github.com/google/go-tpm-tools/simulator" in any of:
 	rm -fv _build/src/github.com/google/go-attestation/attest/attest_simulated_tpm20_test.go
 # src/github.com/google/go-attestation/attest/application_key_test.go:38:14: undefined: setupSimulatedTPM