Bug#1150097: openstack-pkg-tools: package is empty if nocheck specified

[Chris Lamb]

Source: openstack-pkg-tools
Version: 149
Severity: serious
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: nocheck
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
openstack-pkg-tools could not be built reproducibly. This is because the
call to dh_install is accidentally within the "if !nocheck" conditional
in debian/rules, meaning that if nocheck *is* specified, then dh_install
is never called, thus rendering the package essentially empty.

Patch attached for clarity.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2026-10-05 11:07:58.854344880 -0700
--- b/debian/rules	2026-10-05 11:08:18.158855790 -0700
@@ -12,5 +12,5 @@
 		echo "-> Checking $$i" ; \
 		sh -n $$i ; \
 	done
-	dh_install
 endif
+	dh_install