[Reproducible-builds] Bug#762683: libdpkg-perl: add build flags that help with build reproducibility

[Paul Wise]

On Fri, 2014-09-26 at 19:30 +0200, Guillem Jover wrote:

> Please, see
> <https://wiki.debian.org/Teams/Dpkg/FAQ#Q:_Can_we_add_support_for_new_default_build_flags_to_dpkg-buildflags.3F>
> for the process to include it in the default set.

Thanks for the pointer.

> Although for now I'm fine merging this being disabled by default.

Thanks! The attached patches keep it disabled it by default.
We will submit another patch once the requisite steps have been taken.

> Meanwhile I've added support to dpkg-buildflags to honor feature area
> settings from DEB_BUILD_OPTIONS, so that these can be enabled globally by
> a builder for example for build tests and similar, but will be overridden
> by DEB_BUILD_MAINT_OPTIONS though (in the same way build flags are).

Thanks.

> Please change this to “# Default feature states.”, to make it
> independent of their enabled/disabled state, I've already changed
> the original string where this was copied from.
...
> And move this comment to the other patch.

Good points, done in the attached patches.

> I'm thinking that if this gets accepted by the project at large, then
> it might even make sense to make it an error (-Werror=date-time) at
> some later point, so the name would be wrong. How about 'timeless'?
> Or can you think about some other more appropriate name?

I wasn't aware of the -Werror=date-time flag, thanks for pointing it
out. We should indeed transition to making it an error at some point.
Your proposed name sounds perfect, adopted in the attached patches.

> It would be nice if you could add documentation in the dpkg-buildflags
> man page, a new .SS subsection, with something along the lines of the
> first Hardening paragraph (I had already reworked the common parts out
> of the Hardening subsection for other feature areas, so no need to
> repeat those).

Updated each of the patches to include documentation updates too.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-infra-and-docs-for-build-flags-related-to-reprod.patch
Type: text/x-patch
Size: 1948 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20140927/11d9b51e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-option-to-warn-about-using-__TIME__-__DATE__-and.patch
Type: text/x-patch
Size: 1729 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20140927/11d9b51e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20140927/11d9b51e/attachment.sig>