[Reproducible-builds] [Reproducible-commits] [debbindiff] 02/03: debbindiff.py: simplify exit code calculation

[Jérémy Bobbio]

Chris Lamb:
> commit da146535f5d8af3e9b5685dbf597a9f4666ec1c1
> Author: Chris Lamb <lamby at debian.org>
> Date:   Sat Feb 14 11:06:47 2015 +0000
> 
>     debbindiff.py: simplify exit code calculation
> ---
>  debbindiff.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/debbindiff.py b/debbindiff.py
> index 15de0ab..807ec39 100755
> --- a/debbindiff.py
> +++ b/debbindiff.py
> @@ -62,9 +62,7 @@ def main():
>              print(*args, **kwargs)
>          output_html(differences, css_url=parsed_args.css_url, print_func=print_func,
>                      max_page_size=parsed_args.max_report_size)
> -    if len(differences) > 0:
> -        return 1
> -    return 0
> +    return bool(differences)
>  
>  if __name__ == '__main__':
>      sys.exit(main())

Sorry, but no.

The exit code is an interface for users of debbindiff. This change makes
it hard to know what the interface actually is.

-- 
Lunar                                .''`. 
lunar at debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20150214/7fca7974/attachment.sig>