[Reproducible-builds] Bug#796400: golang-github-jacobsa-ratelimit: Non-determistically FTBFS due to unreliable timing in tests

[Chris Lamb]

Source: golang-github-jacobsa-ratelimit
Version: 0.0~git20150723.0.2ca5e0c-1
Severity: serious
Justification: fails to build from source
User: reproducible-builds at lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org

Dear Maintainer,

golang-github-jacobsa-ratelimit's testsuite appears to use method
timing/benchmarking in such
a way that it will non-deterministically FTBFS:

  throttle_test.go:
  		expected := smallerRateHz * (float64(perCaseDuration) /
  		float64(time.Second))

For example:

  [..]
  	go test -v github.com/jacobsa/ratelimit
  === RUN TestThrottle
  [----------] Running tests from ThrottleTest
  [ RUN      ] ThrottleTest.IntegrationTest
  throttle_test.go:202:
  Expected: greater than 135, and less than 165
  Actual:   88
  Test case 0. expected: 150.000000
  
  throttle_test.go:202:
  Expected: greater than 180, and less than 220.00000000000003
  Actual:   138
  Test case 1. expected: 200.000000
  
  throttle_test.go:202:
  Expected: greater than 180, and less than 220.00000000000003
  Actual:   163
  Test case 2. expected: 200.000000
  
  [  FAILED  ] ThrottleTest.IntegrationTest (6.031585896s)
  [----------] Finished with tests from ThrottleTest
  [----------] Running tests from ThrottledReaderTest
  [ RUN      ] ThrottledReaderTest.CallsThrottle
  [       OK ] ThrottledReaderTest.CallsThrottle
  [ RUN      ] ThrottledReaderTest.ThrottleReturnsError
  [       OK ] ThrottledReaderTest.ThrottleReturnsError
  [ RUN      ] ThrottledReaderTest.CallsWrapped
  [       OK ] ThrottledReaderTest.CallsWrapped
  [ RUN      ] ThrottledReaderTest.WrappedReturnsError
  [       OK ] ThrottledReaderTest.WrappedReturnsError
  [ RUN      ] ThrottledReaderTest.WrappedReturnsEOF
  [       OK ] ThrottledReaderTest.WrappedReturnsEOF
  [ RUN      ] ThrottledReaderTest.WrappedReturnsFullRead
  [       OK ] ThrottledReaderTest.WrappedReturnsFullRead
  [ RUN      ] ThrottledReaderTest.WrappedReturnsShortRead_CallsAgain
  [       OK ] ThrottledReaderTest.WrappedReturnsShortRead_CallsAgain
  [ RUN      ]
  ThrottledReaderTest.WrappedReturnsShortRead_SecondReturnsError
  [       OK ]
  ThrottledReaderTest.WrappedReturnsShortRead_SecondReturnsError
  [ RUN      ]
  ThrottledReaderTest.WrappedReturnsShortRead_SecondReturnsEOF
  [       OK ]
  ThrottledReaderTest.WrappedReturnsShortRead_SecondReturnsEOF
  [ RUN      ]
  ThrottledReaderTest.WrappedReturnsShortRead_SecondSucceedsInFull
  [       OK ]
  ThrottledReaderTest.WrappedReturnsShortRead_SecondSucceedsInFull
  [ RUN      ] ThrottledReaderTest.ReadSizeIsAboveThrottleCapacity
  [       OK ] ThrottledReaderTest.ReadSizeIsAboveThrottleCapacity
  [----------] Finished with tests from ThrottledReaderTest
  [----------] Running tests from TokenBucketTest
  [ RUN      ] TokenBucketTest.CarefulAccounting
  [       OK ] TokenBucketTest.CarefulAccounting
  [----------] Finished with tests from TokenBucketTest
  --- FAIL: TestThrottle (6.03s)
  === RUN TestThrottledReader
  --- PASS: TestThrottledReader (0.00s)
  === RUN TestTokenBucket
  --- PASS: TestTokenBucket (0.00s)
  FAIL
  exit status 1
  FAIL    github.com/jacobsa/ratelimit    6.074s
  dh_auto_test: go test -v github.com/jacobsa/ratelimit returned exit
  code 1
  debian/rules:6: recipe for target 'build' failed
  make: *** [build] Error 1
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

  [..]

The full build log is attached or can be viewed here:

    https://reproducible.debian.net/logs/unstable/amd64/golang-github-jacobsa-ratelimit_0.0~git20150723.0.2ca5e0c-1.build2.log.gz


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: golang-github-jacobsa-ratelimit.0.0~git20150723.0.2ca5e0c-1.unstable.amd64.log.txt
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20150821/0a15d026/attachment.txt>