[Reproducible-builds] Bug#797215: getdns: incorrect call to dpkg-parsechangelog could lead to package becoming unreproducible

[Chris Lamb]

Source: getdns
Version: 0.3.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org

Hi dkg,

In debian/rules you attempt to call dpkg-parsechangelog (the program)
as follows:

  $(dpkg-parsechangelog

.. but the lack of any of:

  $(shell dpkg-parsechangelog

  `dpkg-parsechangelog

  $$(dpkg-parsechangelog

.. means that you are actually expanding a /variable/ called
"dpkg-parsechangelog" (!).

This results in passing an empty string to date(1)'s -d argument, which
results in the time rendered being set to midnight of the current
day (!!). The package doesn't appear to be unreproducible though, so the
value is likely not ending up in the final binary.

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: getdns.diff.txt
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20150828/eb456ebd/attachment.txt>