[Reproducible-builds] Bug#807997: diffoscope: CbfsFile checks make diffoscope extra slow
mh+reportbug at glandium.org
Tue Dec 15 05:43:26 UTC 2015
* What led up to the situation?
* What exactly did you do (or not do) that was effective (or
Ran `diffoscope --html output.html firefox-45.0a1.en-US.linux-x86_64.tar.bz2 target.tar.bz2`
* What was the outcome of this action?
It took 9 minutes and 15 seconds on my machine.
* What outcome did you expect instead?
It taking much less time. In fact, after doing some profiling and seeing that
CbfsFile was a hotspot, applying the following patch made the command take 80
seconds instead, most of which is spent bunzip2'ing the two archives
sequentially, and objdump --disassemble'ing libxul.so in the two archives in
parallel (so there could be a win with bunzip2'ing the two archives in
diff --git a/diffoscope/comparators/__init__.py b/diffoscope/comparators/__init__.py
index b4615c9..c4cffbb 100644
@@ -129,7 +129,6 @@ FILE_CLASSES = (
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.2.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
More information about the Reproducible-builds