[Reproducible-builds] Bug#818419: mutt: please make the build reproducible (locale)

[Daniel Shahaf]

Source: mutt
Version: 1.5.24-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that mutt could not be built reproducibly [2]: file ordering inside
README.Patches varies.

While I couldn't reproduce the problem locally (against git 12ae807bfb9e
in sid/sbuild), I believe the following patch should resolve it:

[[[
diff --git a/debian/rules b/debian/rules
index 5d52e30..7b8425d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -144,8 +144,10 @@ install: build
 	
 	chmod +x debian/extra/lib/*
 	chmod +x debian/header.awk
-	debian/header.awk debian/patches/features/* \
-		debian/patches/mutt-patched/* > debian/tmp/README.Patches
+	# Glob expansions are sorted in a locale-sensitive manner; set the
+	# locale to make the order reproducible.
+	(LC_ALL=C; export LC_ALL; debian/header.awk debian/patches/features/* \
+		debian/patches/mutt-patched/*) > debian/tmp/README.Patches
 	
 	( sed -e '/## More settings/,$$d' $(objdir)/doc/Muttrc || exit 1 ; \
 	  cat debian/extra/rc/Muttrc.foot ) > debian/tmp/Muttrc
]]]

Cheers,

Daniel

 [1]: https://wiki.debian.org/ReproducibleBuilds
 [2]: https://tests.reproducible-builds.org/rb-pkg/unstable/amd64/mutt.html