[Reproducible-builds] Bug#819325: angular.js: please make the build reproducible

[Dhole]

Source: angular.js 
Version: 1.3.20-2 
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that angular.js could not be built reproducibly.

When processing translation files and using a non-UTF8 locale, grep
misdetects them as binary files and embeds the line: "Binary file
(standard input) matches"

The attached patch fixes this by telling grep to treat the input as
text. Once applied, angular.js can be built reproducibly in our current
experimental framework.

 [1]: https://wiki.debian.org/ReproducibleBuilds

Regards,
-- 
Dhole
-------------- next part --------------
diff -Nru angular.js-1.3.20/debian/changelog angular.js-1.3.20/debian/changelog
--- angular.js-1.3.20/debian/changelog	2016-03-14 16:57:49.000000000 +0100
+++ angular.js-1.3.20/debian/changelog	2016-03-25 23:51:20.000000000 +0100
@@ -1,3 +1,10 @@
+angular.js (1.3.20-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix misdetection as binary input in grep when LC_ALL=C 
+
+ -- Eduard Sanou <dhole at openmailbox.org>  Fri, 25 Mar 2016 23:50:43 +0100
+
 angular.js (1.3.20-2) unstable; urgency=low
 
   * Don't ship minified files until uglifyjs is updated (closes: #815865).
diff -Nru angular.js-1.3.20/debian/rules angular.js-1.3.20/debian/rules
--- angular.js-1.3.20/debian/rules	2016-03-14 16:54:56.000000000 +0100
+++ angular.js-1.3.20/debian/rules	2016-03-25 23:50:34.000000000 +0100
@@ -33,7 +33,7 @@
 		echo \'use strict\'\;) \
 			>$(CURDIR)/debian/build/angular.js-head
 	ln -s $(CURDIR)/debian/smash-angularSrc.js $(CURDIR)
-	smash $(CURDIR)/smash-angularSrc.js | egrep -v 'use strict' \
+	smash $(CURDIR)/smash-angularSrc.js | egrep -a -v 'use strict' \
 		>$(CURDIR)/debian/build/angular.js-body
 	cat $(CURDIR)/debian/build/angular.js-head \
 		$(CURDIR)/debian/build/angular.js-body \
@@ -108,7 +108,7 @@
 	(cat $(CURDIR)/src/module.prefix && \
 		echo \'use strict\'\;) \
 			>$(CURDIR)/debian/build/angular.js-module_head
-	smash $(CURDIR)/smash-ngRoute.js | egrep -v 'use strict' \
+	smash $(CURDIR)/smash-ngRoute.js | egrep -a -v 'use strict' \
 		>$(CURDIR)/debian/build/angular.js-route_body
 	cat $(CURDIR)/debian/build/angular.js-module_head \
 		$(CURDIR)/debian/build/angular.js-route_body | \
@@ -120,7 +120,7 @@
 
 	# angular-sanitize.js
 	ln -s $(CURDIR)/debian/smash-ngSanitize.js $(CURDIR)
-	smash $(CURDIR)/smash-ngSanitize.js | egrep -v 'use strict' \
+	smash $(CURDIR)/smash-ngSanitize.js | egrep -a -v 'use strict' \
 		>$(CURDIR)/debian/build/angular.js-sanitize_body
 	cat $(CURDIR)/debian/build/angular.js-module_head \
 		$(CURDIR)/debian/build/angular.js-sanitize_body | \
@@ -132,7 +132,7 @@
 
 	# angular-touch.js
 	ln -s $(CURDIR)/debian/smash-ngTouch.js $(CURDIR)
-	smash $(CURDIR)/smash-ngTouch.js | egrep -v 'use strict' \
+	smash $(CURDIR)/smash-ngTouch.js | egrep -a -v 'use strict' \
 		>$(CURDIR)/debian/build/angular.js-touch_body
 	cat $(CURDIR)/debian/build/angular.js-module_head \
 		$(CURDIR)/debian/build/angular.js-touch_body | \
@@ -147,7 +147,7 @@
 	((cat $(CURDIR)/src/loader.prefix | egrep -v  'use strict') && \
 		echo \'use strict\'\;) \
 			>$(CURDIR)/debian/build/angular.js-loader_head
-	smash $(CURDIR)/smash-angularLoader.js | egrep -v 'use strict' \
+	smash $(CURDIR)/smash-angularLoader.js | egrep -a -v 'use strict' \
 		>$(CURDIR)/debian/build/angular.js-loader_body
 	cat $(CURDIR)/debian/build/angular.js-loader_head \
 		$(CURDIR)/debian/build/angular.js-loader_body | \
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160326/169a0f1d/attachment.sig>