[Reproducible-builds] Bug#818856: Bug#818856: diffoscope: crashes on broken symlinks

[Paul Wise]

On Thu, 2016-04-07 at 00:42 +0530, Satyam Zode wrote:

> Thank you for reviewing patch. I have made all the changes you
> mentioned above. Please find an attachment :-)

This will works better but will still give a crash when both symlinks
are broken and point to a filename of the same length; because open()
throws an IOError exception when it tries to open a broken symlink.

In addition, I think we need a test for this issue written before
fixing the issue, here are some test cases I can think of:

one broken symlink, one file

one file, one broken symlink
one broken symlink, one dir

one dir, one broken symlink
one working symlink to a file, one broken symlink
one broken symlink, one working symlink to a file
one working symlink to a dir, one broken symlink
one broken symlink, one
working symlink to a dir
two broken symlinks pointing at the same
location
two broken symlinks of the same size but different locations
two broken symlinks of different sizes

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160407/a99f1d80/attachment.sig>