[Reproducible-builds] Support for --ignore-profile flag in diffoscope

Holger Levsen holger at layer-acht.org
Fri May 13 11:12:16 UTC 2016


On Fri, May 13, 2016 at 12:44:11PM +0200, Ximin Luo wrote:
> Concretely I have some suggestions:
> 
> 1. instead of calling this "ignore" we call it "hide". and instead of "irrelevant" we say "common"/"minor"/"known"
 
strong ACK. 

I really really like "--hide-timestamps" much better than
"--ignore-timestamps", because the latter somewhat implies that ignoring
this is ok, while hiding clearly conveys there is something, hidden.

> 2. diffoscope --ignore-* (or --hide-*) MUST NOT return 0 or otherwise give the impression that two non-identical files are the same, even if all differences are "hidden". It should report "n differences hidden".

hm. maybe it would be ok to exit with 0 when using --hide options if one
also adds _another_ option, like --hide-error-on-exit or
--pretend-clean-if-hidden-well or such?


-- 
cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160513/ceb8cebf/attachment.sig>


More information about the Reproducible-builds mailing list