[Reproducible-builds] Bug#824182: codeblocks: please make the build reproducible (timestamps)

[Ximin Luo]

Ximin Luo:
> (sorry for repost, making sure the right people see this)
> 
> Fabian Wolff:
>> -export DEB_CPPFLAGS_MAINT_APPEND=-DNDEBUG
>> +export DEB_CPPFLAGS_MAINT_APPEND=-DNDEBUG \
>> +	-DBUILD_DATE="\"\\\"`date -u -d @$(SOURCE_DATE_EPOCH) +%Y-%m-%d`\\\"\"" \
>> +	-DBUILD_TIME="\"\\\"`date -u -d @$(SOURCE_DATE_EPOCH) +%T`\\\"\""
> 
> Hi Fabian,
> 
> Have you tested this patch? My understanding is that debhelper sets SOURCE_DATE_EPOCH but make(1) does not. In general, debian/rules is a plain Makefile and shouldn't assume higher-level tools set anything extra.
> 

On a second look, it seems everything in this particular debian/rules is done inside override_dh* rules, so it may be the case that dpkg-buildflags (who expands DEB_CPPFLAGS_MAINT_APPEND) will always see SOURCE_DATE_EPOCH.

So everything may be fine. If that's the case, sorry for the noise. (Then it would be nice to add a comment explaining this, for future readers.)

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git