[Reproducible-builds] Bug#806331: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

[Ximin Luo]

(Did you mean to add debian-bugs-dist and Jonathan Nieder on purpose or by accident? I removed them, but feel free to add them back in.)

Thorsten Glaser:
>> proposed patch affect your scenario? This is not about CONFIG_SHELL,
> 
> It is. Straight from your diff:
> 
>>      for gl_cv_posix_shell in \
>> -        "$CONFIG_SHELL" "$SHELL" /bin/sh /bin/bash /bin/ksh /bin/sh5 no; do
>> +        /bin/sh /bin/bash /bin/ksh /bin/sh5 "$CONFIG_SHELL" "$SHELL" no; do
> 
> This makes $CONFIG_SHELL no longer the preferred POSIX shell.
> 
> This breaks when a system has a /bin/sh that passes all gnulib
> tests (and thus is used as POSIX_SHELL) but has other bugs that
> make it unusable, for example. The user can then no longer over‐
> ride this bad choice of the configury.
> 

In such a case, it is a bug to be using $POSIX_SHELL - which only tests for conformance with POSIX and not these "other bugs that make it unusable".

In other words: in your scenario, one would not use $POSIX_SHELL but some other specific test for those "other bugs".

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git