[Reproducible-builds] Bug#827382: dwarfutils: does not build reproducibly

[Fabian Wolff]

On Wed, Jun 15, 2016 at 07:47:20PM +0200, Reiner Herrmann wrote:
> I found that the problem is in a C file which is generated during build
> (tmp-tt-table.c).  It contains some tables, and the last two elements
> columsn of one table were not deterministic.
> The reason is that the array is sized incorrectly.
> 
> It is declared as:
> 
>   unsigned int tag_tree_combination_table[TAG_TABLE_ROW_MAXIMUM][TAG_TABLE_COLUMN_MAXIMUM];
> 
> where TAG_TABLE_COLUMN_MAXIMUM was set to EXT_TAG_TABLE_COLS, which is 5.
> But when calling this tool with -s, it uses STD_TAG_TABLE_COLUMNS for
> iterating over the table, which is 7 -> two elements more than the table
> is wide, which causes memory from outside the table to be written into
> the file.
> 
> The attached patch fixes this by setting the maximum column width to
> STD_TAG_TABLE_COLUMNS.

Amazing. Thank you very much!