[Reproducible-builds] Bug#829113: Bug#829113: reprotest: Should unset $DISPLAY to avoid GUI popups from some build tools

[Jérémy Bobbio]

Hi Axel!

Axel Beckert:
> Running
> 
> $ reprotest 'dpkg-buildpackage -b' ../debian-paketmanagement-buch_0\~2016.06.29_all.deb
> 
> from a git checkout of commit 5f069a920df4e6f20a8eb9309c20c39ad60e6132
> under X to see if my $SOURCE_DATE_EPOCH implementation in that commit is
> working correctly.
> 
>    * What was the outcome of this action?
> 
> Two GUI popups from ebook-convert (from the package calibre) moaning
> about non-existent $HOME and hence unreadable $HOME/.config/…
> 
>    * What outcome did you expect instead?
> 
> No interactivity, especially no GUI interactivity at all.
> 
> Unsetting $DISPLAY should this issue.
> 
> (I'm not sure if setting and not setting $DISPLAY is or should be one of
> the not explicitly listed variations. But since I got that popup twice,
> I assume not.)

I don't think this is a bug in reprotest. As far as I can see by looking
in dpkg source tree, `dpkg-buildpackage` doesn't do anything to the
DISPLAY variable etiher. So I would assume building the package might
fail just as well without reprotest. If building the package requires to
unset DISPLAY, I think this should be done in `debian/rules`…

One take though, maybe reprotest should ensure that $HOME is set to an
existing (temporary) directory; other building tools might get unhappy.

-- 
Lunar                                .''`. 
lunar at debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160701/ae8bb6f6/attachment.sig>