[Reproducible-builds] Bug#832306: dh-strip-nondeterminism: png file handling is messed up

[James Cowgill]

Package: dh-strip-nondeterminism
Version: 0.020-1
Severity: grave

Hi,

The new version of dh-strip-nondeterminism messes up handling of png
files. This is a regression from 0.019-1

When run on kmidimon which I was working on, 0.020-1 gives (and doesn't
fail on):

dh_strip_nondeterminism -pkmidimon 
debian/kmidimon/usr/share/doc/kde/HTML/en/kmidimon/qjackctl.png: invalid length in ��I� header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/en/kmidimon/kmidimon1.png: invalid length in >�7H header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/en/kmidimon/kmidimon3.png: invalid length in R��k header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/en/kmidimon/kmidimon2.png: invalid length in 
                                                                                    ��3 header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/ja/kmidimon/qjackctl.png: invalid length in ��I� header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/ja/kmidimon/kmidimon1.png: invalid length in >�7H header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/ja/kmidimon/kmidimon3.png: invalid length in R��k header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/doc/kde/HTML/ja/kmidimon/kmidimon2.png: invalid length in 
                                                                                    ��3 header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/icons/hicolor/64x64/apps/kmidimon.png: invalid length in HYs header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 96.
debian/kmidimon/usr/share/icons/hicolor/48x48/apps/kmidimon.png: invalid length in HYs header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 96.
debian/kmidimon/usr/share/icons/hicolor/24x24/apps/kmidimon.png: invalid length in HYs header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 96.
debian/kmidimon/usr/share/icons/hicolor/128x128/apps/kmidimon.png: invalid length in HYs header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 119.
debian/kmidimon/usr/share/icons/hicolor/32x32/apps/kmidimon.png: invalid length in HYs header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 96.
debian/kmidimon/usr/share/icons/hicolor/16x16/apps/kmidimon.png: invalid length in HYs header at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 96.

It then proceeds to write out a load of dodgy looking files into the
package. Output from debc (note the random filenames which were not
there before):

drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/128x128/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/128x128/apps/
-rw-r--r-- root/root      4330 2016-07-23 21:03 ./usr/share/icons/hicolor/128x128/apps/kmidimon.png
-rw-r--r-- root/root      1893 2016-07-24 00:17 ./usr/share/icons/hicolor/128x128/apps/rCuFnLpl3Z
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/16x16/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/16x16/apps/
-rw-r--r-- root/root        33 2016-07-24 00:17 ./usr/share/icons/hicolor/16x16/apps/9wtJKNTsBO
-rw-r--r-- root/root       478 2016-07-23 21:03 ./usr/share/icons/hicolor/16x16/apps/kmidimon.png
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/24x24/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/24x24/apps/
-rw-r--r-- root/root        33 2016-07-24 00:17 ./usr/share/icons/hicolor/24x24/apps/a1X6RR9dWI
-rw-r--r-- root/root       694 2016-07-23 21:03 ./usr/share/icons/hicolor/24x24/apps/kmidimon.png
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/32x32/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/32x32/apps/
-rw-r--r-- root/root        33 2016-07-24 00:17 ./usr/share/icons/hicolor/32x32/apps/Np6sI59bG9
-rw-r--r-- root/root       937 2016-07-23 21:03 ./usr/share/icons/hicolor/32x32/apps/kmidimon.png
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/48x48/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/48x48/apps/
-rw-r--r-- root/root      1419 2016-07-23 21:03 ./usr/share/icons/hicolor/48x48/apps/kmidimon.png
-rw-r--r-- root/root        33 2016-07-24 00:17 ./usr/share/icons/hicolor/48x48/apps/xku0MRLVxE
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/64x64/
drwxr-xr-x root/root         0 2016-07-24 00:17 ./usr/share/icons/hicolor/64x64/apps/
-rw-r--r-- root/root        33 2016-07-24 00:17 ./usr/share/icons/hicolor/64x64/apps/cXxgSVYt6j
-rw-r--r-- root/root      1992 2016-07-23 21:03 ./usr/share/icons/hicolor/64x64/apps/kmidimon.png

Thanks,
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160724/5c949d0c/attachment.sig>