[Reproducible-builds] Bug#832306: closed by Chris Lamb <lamby at debian.org> (Bug#832306: fixed in strip-nondeterminism 0.021-1)

[James Cowgill]

On Sun, 2016-07-24 at 12:06 +0000, Debian Bug Tracking System wrote:
> This is an automatic notification regarding your Bug report
> which was filed against the dh-strip-nondeterminism package:
> 
> #832306: dh-strip-nondeterminism: png file handling is messed up
> 
> It has been closed by Chris Lamb <lamby at debian.org>.

From Git:
> diff --git a/lib/File/StripNondeterminism/handlers/png.pm b/lib/File/StripNondeterminism/handlers/png.pm
> index 793250e..87235cd 100644
> --- a/lib/File/StripNondeterminism/handlers/png.pm
> +++ b/lib/File/StripNondeterminism/handlers/png.pm
> @@ -107,6 +107,11 @@ sub _normalize {
>                                 $modified = 1;
>                                 next;
>                         }
> +
> +                       # Not a chunk we care about but we already read the
> +                       # data so we cannot fall through
> +                       print $tempfile $header . $data;
> +                       next;
>                 }
>  
>                 print $tempfile $header;

This seems to break the IEND "garbage after png file" handling. The
testcase from #802057 fails after this.

James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160724/c257b218/attachment.sig>