[Reproducible-builds] Bug#832096: lintian: please check for common typos in debian/rules target names

[Jakub Wilk]

Hi Chris!

Thanks for the updated patch.

* Chris Lamb <lamby at debian.org>, 2016-07-23, 20:13:
>+Certainty: certain

Shouldn't it be "possible"? After all, our list of dh_* commands might 
be out of date.

>+                # Unknown command, so check for likely misspellings
>+                foreach my $x ($dh_commands_depends->all) {
>+                    if (distance($dhcommand, $x) < 3) {
>+                        tag 'typo-in-debhelper-override-target',
>+                          "override_$dhcommand", '->', "override_$x", "(line $.)";

This doesn't work that well if the typoed command is in close distance 
to multiple existing commands. For example, for "override_dh_nump" I get 
this (in non-deterministic order):

W: hello source: typo-in-debhelper-override-target override_dh_nump -> override_dh_numpy3 (line 11)
W: hello source: typo-in-debhelper-override-target override_dh_nump -> override_dh_numpy (line 11)

-- 
Jakub Wilk