[Reproducible-builds] Bug#834774: gkrellm: please make the build reproducible

[Chris Lamb]

Source: gkrellm
Version: 2.3.7-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that gkrellm could not be built reproducibly.

This was because dh_fixperms was not being called (to avoid mangling
the existing chmod), meaning that files were installed to the .deb
varying on the current umask.

The solution is to reinstate the call to dh_fixperms but to use its
--exclude argument.

Patch attached.


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/11_reproducible_build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/11_reproducible_build.patch	2016-08-18 23:15:25.450065961 +0100
@@ -0,0 +1,23 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2016-08-18
+
+--- gkrellm-2.3.7.orig/Makefile
++++ gkrellm-2.3.7/Makefile
+@@ -98,6 +98,7 @@ ifeq ($(INSTALLROOT),)
+ 	INSTALLROOT = /usr/local
+ endif
+ 
++SHELL = /bin/bash
+ INSTALLDIR = $(INSTALLROOT)/bin
+ SINSTALLDIR ?= $(INSTALLDIR)
+ MANDIR ?= $(INSTALLROOT)/share/man/man1
+@@ -131,7 +132,7 @@ all gkrellm: gkrellm.pc
+ 	(cd server && ${MAKE} gkrellmd)
+ 
+ gkrellm.pc: Makefile
+-	echo 'prefix=$(INSTALLROOT)\n'\
++	echo -e 'prefix=$(INSTALLROOT)\n'\
+ 	'Name: GKrellM\n'\
+ 	'Description: Extensible GTK system monitoring application\n'\
+ 	'Version: $(VERSION)\n'\
--- a/debian/patches/series	2016-08-18 23:05:15.325157840 +0100
--- b/debian/patches/series	2016-08-18 23:15:23.206047861 +0100
@@ -2,3 +2,4 @@
 04_fix_manpage_hyphen.patch
 05_bts437033_fix_strip.patch
 10_fix_glib_underlinkage.patch
+11_reproducible_build.patch