Bug#835642: diffoscope: traceback when comparing symlink to directory

[Chris Lamb]

Package: diffoscope
Version: 59
Severity: normal


$ mkdir -p a/dst b/dst

$ ln -sT dst a/src

$ ln -sT dst b/src

$ ls -l a b
a:
total 4
drwxr-xr-x 2 lamby lamby 4096 Aug 27 23:04 dst
lrwxrwxrwx 1 lamby lamby    3 Aug 27 23:04 src -> dst

b:
total 4
drwxr-xr-x 2 lamby lamby 4096 Aug 27 23:04 dst
lrwxrwxrwx 1 lamby lamby    3 Aug 27 23:04 src -> dst

$ diffoscope a b
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 200, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 171, in run_diffoscope
    parsed_args.path1, parsed_args.path2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/__init__.py", line 97, in compare_root_paths
    return compare_directories(path1, path2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 103, in compare_directories
    return FilesystemDirectory(path1).compare(FilesystemDirectory(path2))
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 156, in compare
    my_file, other_file, source=name)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/__init__.py", line 107, in compare_files
    if file1.has_same_content_as(file2):
  File "/usr/lib/python3/dist-packages/diffoscope/__init__.py", line 252, in tool_check
    return original_function(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/binary.py", line 196, in has_same_content_as
    if open(self.path, 'rb').read() == open(other.path, 'rb').read():
IsADirectoryError: [Errno 21] Is a directory: 'a/src'


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-