[Reproducible-builds] Minimising work needed for this build-path issue

Ximin Luo infinity0 at debian.org
Mon Sep 12 14:22:00 UTC 2016


Daniel Kahn Gillmor:
> On Fri 2016-09-09 01:33:00 +0200, HW42 wrote:
>> According to codesearch.d.n it seems only SOURCE_DIR_ROOT isn't taken
>> yet. (Google finds at least one case).
> 
> thanks for looking, that's what i should have done in the first place.
> 
>> also bikeshedding: I dislike SOURCE_DIR_ROOT because the name is some
>> how redundant. What's the difference between SOURCE_DIR and
>> SOURCE_DIR_ROOT? But I don't care much about the naming.
> 
> if i've got some source with code in three directories, they're all
> SOURCE_DIRs, but only the top level is SOURCE_DIR_ROOT.
> 

I can see the benefit in choosing the name carefully; here are my suggestions:

SOURCE_ROOTDIR
SOURCE_TOPDIR
<del>SOURCE_PREFIX</del> oh, already used by firefox :(

I preferred the ${x}dir style instead of dir_${x} or ${x}_dir because of some existing conventions like

https://www.gnu.org/prep/standards/html_node/Directory-Variables.html

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git



More information about the Reproducible-builds mailing list