Bug#841342: zshdb: FTBFS under some locales (eg. fr_CH.UTF-8)

[Chris Lamb]

Source: zshdb
Version: 0.92-1
Severity: serious
Justification: fails to build from source
User: reproducible-builds at lists.alioth.debian.org
Usertags: ftbfs locale
Tags: patch
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org


Dear Maintainer,

zshdb fails to build from source in unstable/amd64 under some
locales (eg. LANG="fr_CH.UTF-8").

The code already tries to work around this:

  54 # set the constants readonly
  55 shunit_constants_=`set |grep '^__SHUNIT_' |cut -d= -f1`
  56 echo "${shunit_constants_}" |grep '^Binary file' >/dev/null && \
  57     shunit_constants_=`set |grep -a '^__SHUNIT_' |cut -d= -f1`

… but this doesn't work if the "Binary file" message is in, say, French :)

Changing this:

  - shunit_constants_=`set |grep '^__SHUNIT_' |cut -d= -f1`
  + shunit_constants_=`set |LC_ALL=C grep '^__SHUNIT_' |cut -d= -f1`

… makes this appear to work, but then you get other errors:

--- /tmp/setshow-filtered.check	2016-10-19 18:22:06.324491603 +0200
+++ zshdb-0.92/test/data/setshow.right	2016-07-06 18:47:42.000000000 +0200
@@ -1,4 +1,3 @@
-** pas un tty is not reputed to be a tty.
 (dbg-test2.sh:6):
 fn1 () { echo "fn1 here" x=5 fn3 }

etc. etc.

One solution (attached) is to simply set LC_ALL=C when running the
tests, but that suggests it would still fail at runtime and we are
just masking that issue? I would speak to upstream.

The full build log is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zshdb.0.92-1.unstable.amd64.log.txt.gz
Type: application/octet-stream
Size: 5203 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161019/60839e68/attachment.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: zshdb.diff.txt
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161019/60839e68/attachment.txt>