Bug#841146: diffoscope: Failure of test_superblock
mattia at debian.org
Fri Oct 21 16:23:51 UTC 2016
On Tue, Oct 18, 2016 at 03:33:14PM -0400, Leo Famulari wrote:
> > > =================================== FAILURES ===================================
> > > _______________________________ test_superblock ________________________________
> > >
> > > differences = 
> > >
> > > @skip_unless_tool_is_older_than('unsquashfs', unsquashfs_version, '4.3')
> > > def test_superblock(differences):
> > > expected_diff = open(data('squashfs_superblock_expected_diff')).read()
> > > > assert differences.unified_diff == expected_diff
> > > E IndexError: list index out of range
I just can't reproduce this.
Though I'm using pytest 3.0.3.
That test is skipped by using pytest.mark.skip(), which I don't see in
the docs of pytest for 2.7.
The changelog of pytest tells me pytest.mark.skip() is recognized as a
skipping marker starting from 2.9¹. Is there any chance you can instead
upgrade pytest in your distribution? If so I'll add a versioned
dependency on setup.py, otherwies I can always turn that
pytest.mark.skip() into a pytest.mark.skipif(True), which is IMHO ugly
but quick and effective for solving this bug, I think. Can you also try
to convert that marking in tests/comparators/utils.py:49 to confirm?
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 801 bytes
Desc: not available
More information about the Reproducible-builds